a69 cosmetic issues and bug system did not work for me

[Jochen Peters]

Hi Michael!

> Datasources column + at column bottom gets Connect to Valentina 
> Server/ODBC datasource dialog. Several problems as I see it.
>
> 1) Datasourc is missing the e.
Ok.

>
> 2) Do you really want the dialog Title Bar to change depending on the 
> dataource type selected? I suppose it makes some sense.
I think yes.

>
> 3) In Datasourc you have ODBC datasource but in the Title Bar you have 
> ODBC data source as two words not one.
Ok - which one is correct? I guess one word, datasource, yes?

>
> 4) Why not include Valentina data files here as a potential datasource 
> option in this dialog?
Yes - this would be possible. On the other hand for local files all of 
the options in this dialog makes no sense - instead for
local files we only need a file select box. So - i think this "Connect 
to.." dialog is for remote databases only,

>
> 5) + sign to me means add, so I would expect to create any database 
> file when clicking the +, even the Valentina 1.x and 2.x types. In 
> other words, I expect the + to act the same as menu item File select 
> New database. But you are using the + as similar to menu item File 
> select Open database, except ODBC and Valentina Server rather than 
> Valentina databases are opened. Have you noticed that in the four VS 
> columns you have inconsistent use of + and -? In the Datasources 
> column + is open and - is close, while in the other columns + is 
> create and - is delete supposedly. I think this difference may cause 
> confusion. Why not have two more buttons at Datasources column bottom 
> for open and close datasources and use + for create and - for delete.
Yes - i am aware of this inconsistent use. This must be fixed. In the 
first run i have implemented this only because i have used it in the 
development process - i simply need a button to quickly open/close a 
database. You are absolutly right - i will connect the + button with 
the create dialog.
Maybe it would be better to have some other buttons for the first two 
columns - because it makes no sense to delete database files from 
inside
vStudio...


> Which brings up another point, I would suggest using the same 
> terminology in the columns as in the menu so either create in both 
> places or new in both places. For example my people will be confused 
> that New database gets created as a Datasource Elements. Also if you 
> can create a New database through File menu, where is the option to 
> delete it through the File menu? In addition, delete Datasource 
> elements - at column bottom does not work like I expect that it 
> should. It apparently closes but does not actually delete the 
> datasource element since I see the supposedly deleted datasource 
> element on my hard drive. It appears that the - really acts to close 
> the datasource element and I am not sure that is what you want?
See above. I think delete makes no sense here - but this can be easily 
fixed by choosing some other button - so we will not have a "-" button 
at the
bottom of the first two columns - instead we will have a "close" button.
>
> Why is it bad to have Open database as a main menu item with four or 
> more submenu selections?
Yes - this is possible. Well - i can easy implement this for the next 
build - so we can test if this is better.

>
> Thanks for being open to discussion,
Thanks for your suggestions, Michael!

>
-- 
Best regards,
Jochen Peters
PIIT GmbH

------------------------------------
http://www.valentina-db.de